[experiment] Switch from LocalID to Alias #8025
Open
+30
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to overcome the sometimes cryptic use of
Cluster.LocalID
.In the past we didn't parametrize our cluster-wide resources (such as IAM roles) because there was no need for it since the Kubernetes stack was only created once per account. The introduction of multiple e2e clusters in the very same e2e account changed that and let to the need to occasionally add the
Cluster.LocalID
parameter to the resource names. However, the list grew and with the outlook of having multiple clusters in many accounts will only intensify.Unfamiliar users, such as new team members or other platform teams, are even more surprised by the need of this parameter as they haven't been exposed to multiple clusters in the accounts up until now.
In order to make this concept more clear and understandable, this PR changes it to use the
Cluster.Alias
. The alias is globally unique and hence will also be unique in the same account, likeCluster.LocalID
. In addition, the more familiar alias value is easier to understand and unforeseen future name conflicts are avoided proactively by making the alias part of each AWS resource name.