Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add podAnnotations for deployment #141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Anton0C
Copy link

@Anton0C Anton0C commented Sep 10, 2024

Added support for customizable pod annotations in the deployment.yaml and values.yaml files.

  • Introduced a new podAnnotations field in values.yaml to allow users to define custom annotations for pods.
  • Updated deployment.yaml to apply annotations from values.yaml using Helm's templating system.
  • Removed redundant end statement in tolerations block for cleaner YAML structure.

@Anton0C
Copy link
Author

Anton0C commented Sep 13, 2024

@zakkg3 Please review

@Anton0C
Copy link
Author

Anton0C commented Sep 20, 2024

Any updates with it ?

@zakkg3
Copy link
Owner

zakkg3 commented Sep 20, 2024

I have to fix the e2e test and if that passes ill merge this. I guess in the next days I hope I find the time for this.
sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants