Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

client config: add parameter to specify connections to client #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trefzer
Copy link
Contributor

@trefzer trefzer commented Dec 17, 2020

No description provided.

@trefzer trefzer force-pushed the fix_add_connections branch from 6a73522 to 3f42e0b Compare January 4, 2021 17:35
<%- @connections.each do | connection | -%>
<%- %><connection>
<%- connection.each do | key, val | -%>
<%= key %> <%= val %>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be left aligned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no there is not need to left align. the config file would look like:

<connection>
       remote somehost.somewhere.com
       port 1194
       proto udp
</connection>
<connection>
       remote otherhost
       .....

so it's much more readable if not left aligned.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see.

Copy link
Owner

@zachfi zachfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Rebase and I'll merge.

@trefzer trefzer force-pushed the fix_add_connections branch from 3f42e0b to 14de165 Compare February 8, 2021 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants