Skip to content

Drag bug fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altaudio wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drag bug fix #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7442fe
Uses height and width if one child node is present
richardgill Aug 15, 2017
cdd36e6
Removes -modified from package name
richardgill Aug 15, 2017
8463acc
Modifies comment
richardgill Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/element-pan.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ var ElementPan = React.createClass({
eventListener.add(window, 'mouseup', this.onDragStop);
eventListener.add(window, 'touchend', this.onDragStop);

// If we have multiple child nodes, use the scroll[Height/Width]
// If we have any child nodes, use the scroll[Height/Width]
// If we have no child-nodes, use bounds to find size of inner content
var bounds, target = e.currentTarget || e.target;
if (target.childNodes.length > 1) {
if (target.childNodes.length > 0) {
bounds = { width: target.scrollWidth, height: target.scrollHeight };
} else {
bounds = e.target.getBoundingClientRect();
Expand Down