Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PyThresh V1 #623

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

KulikDM
Copy link
Contributor

@KulikDM KulikDM commented Jan 30, 2025

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

Hi, this commit aligns PyOD with PyThresh V1, making it a standard that aligns better with the Sklearn and PyOD API having fit and predict functions. Documentation has been updated and two new thresholders have been made available.

Note, that the minimum requirement for using PyThresh in PyOD is now V1 but the benefits (able to threshold on test data correctly with respect to train data) outweighs the downsides. Older versions of PyOD will still work with the new PyThresh but not vice versus.

Hope you are happy with this commit and that it makes PyOD even better than it already is!

@coveralls
Copy link

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13059640949

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 95.364%

Totals Coverage Status
Change from base Build 12743748830: 0.003%
Covered Lines: 10368
Relevant Lines: 10872

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants