Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions Basics:
All Submissions Cores:
Hi, this commit aligns
PyOD
withPyThresh
V1, making it a standard that aligns better with theSklearn
andPyOD
API havingfit
andpredict
functions. Documentation has been updated and two new thresholders have been made available.Note, that the minimum requirement for using
PyThresh
inPyOD
is now V1 but the benefits (able to threshold on test data correctly with respect to train data) outweighs the downsides. Older versions ofPyOD
will still work with the newPyThresh
but not vice versus.Hope you are happy with this commit and that it makes
PyOD
even better than it already is!