fix: HttpPost AlertTemplateFile and RowTemplateFile work with either …

…unix- or windows-like paths (influxdata#2767)

services/httppost/config.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 	"strings"
 	"text/template"
 
@@ -70,15 +70,15 @@ func (c Config) Validate() error {
 		return errors.New("must specify only one of alert-template and alert-template-file")
 	}
 
-	if c.AlertTemplateFile != "" && !path.IsAbs(c.AlertTemplateFile) {
+	if c.AlertTemplateFile != "" && !filepath.IsAbs(c.AlertTemplateFile) {
 		return errors.New("must use an absolute path for alert-template-file")
 	}
 
 	if c.RowTemplate != "" && c.RowTemplateFile != "" {
 		return errors.New("must specify only one of row-template and row-template-file")
 	}
 
-	if c.RowTemplateFile != "" && !path.IsAbs(c.RowTemplateFile) {
+	if c.RowTemplateFile != "" && !filepath.IsAbs(c.RowTemplateFile) {
 		return errors.New("must use an absolute path for row-template-file")
 	}
 

services/httppost/config_test.go

@@ -0,0 +1,71 @@
+//go:build !windows
+
+package httppost
+
+import (
+	"testing"
+)
+
+func Test_Validate_ShouldNotReturnError_WhenAlertTemplateFileIsUnixLikePath(t *testing.T) {
+	testCases := []struct {
+		config Config
+		err    error
+	}{
+		{
+			config: Config{
+				Endpoint:          "test",
+				URLTemplate:       "http://localhost:8080/alert",
+				AlertTemplateFile: "/etc/kapacitor/templates/alert_template.json",
+			},
+			err: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		validationErr := tc.config.Validate()
+
+		if validationErr != nil {
+			if tc.err == nil {
+				t.Errorf("unexpected error: got %v", validationErr)
+			} else if tc.err.Error() != validationErr.Error() {
+				t.Errorf("unexpected error message: got %q exp %q", validationErr.Error(), tc.err.Error())
+			}
+		} else {
+			if tc.err != nil {
+				t.Errorf("expected error: %q got nil", tc.err.Error())
+			}
+		}
+	}
+}
+
+func Test_Validate_ShouldNotReturnError_WhenRowTemplateFileIsUnixLikePath(t *testing.T) {
+	testCases := []struct {
+		config Config
+		err    error
+	}{
+		{
+			config: Config{
+				Endpoint:        "test",
+				URLTemplate:     "http://localhost:8080/alert",
+				RowTemplateFile: "/etc/kapacitor/templates/row_template.json",
+			},
+			err: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		validationErr := tc.config.Validate()
+
+		if validationErr != nil {
+			if tc.err == nil {
+				t.Errorf("unexpected error: got %v", validationErr)
+			} else if tc.err.Error() != validationErr.Error() {
+				t.Errorf("unexpected error message: got %q exp %q", validationErr.Error(), tc.err.Error())
+			}
+		} else {
+			if tc.err != nil {
+				t.Errorf("expected error: %q got nil", tc.err.Error())
+			}
+		}
+	}
+}

services/httppost/config_windows_test.go

@@ -0,0 +1,71 @@
+//go:build windows
+
+package httppost
+
+import (
+	"testing"
+)
+
+func Test_Validate_ShouldNotReturnError_WhenAlertTemplateFileIsWindowsLikePath(t *testing.T) {
+	testCases := []struct {
+		config Config
+		err    error
+	}{
+		{
+			config: Config{
+				Endpoint:          "test",
+				URLTemplate:       "http://localhost:8080/alert",
+				AlertTemplateFile: "C:\\InfluxData\\kapacitor\\templates\\alert_template.json",
+			},
+			err: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		validationErr := tc.config.Validate()
+
+		if validationErr != nil {
+			if tc.err == nil {
+				t.Errorf("unexpected error: got %v", validationErr)
+			} else if tc.err.Error() != validationErr.Error() {
+				t.Errorf("unexpected error message: got %q exp %q", validationErr.Error(), tc.err.Error())
+			}
+		} else {
+			if tc.err != nil {
+				t.Errorf("expected error: %q got nil", tc.err.Error())
+			}
+		}
+	}
+}
+
+func Test_Validate_ShouldNotReturnError_WhenRowTemplateFileIsWindowsLikePath(t *testing.T) {
+	testCases := []struct {
+		config Config
+		err    error
+	}{
+		{
+			config: Config{
+				Endpoint:        "test",
+				URLTemplate:     "http://localhost:8080/alert",
+				RowTemplateFile: "C:\\InfluxData\\kapacitor\\templates\\row_template.json",
+			},
+			err: nil,
+		},
+	}
+
+	for _, tc := range testCases {
+		validationErr := tc.config.Validate()
+
+		if validationErr != nil {
+			if tc.err == nil {
+				t.Errorf("unexpected error: got %v", validationErr)
+			} else if tc.err.Error() != validationErr.Error() {
+				t.Errorf("unexpected error message: got %q exp %q", validationErr.Error(), tc.err.Error())
+			}
+		} else {
+			if tc.err != nil {
+				t.Errorf("expected error: %q got nil", tc.err.Error())
+			}
+		}
+	}
+}