Potential fix for code scanning alert no. 1: Incomplete URL substring sanitization#1
Merged
Potential fix for code scanning alert no. 1: Incomplete URL substring sanitization#1
Conversation
… sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Skip dependency review on private repos without GitHub Advanced Security
Fixes CodeQL alert: Incomplete URL substring sanitization
- Replace unsafe .includes('socket.io') with proper URL pathname parsing
- Only match /socket.io or /socket.io/* paths (standard Socket.IO paths)
- Extract SignalR detection to separate helper function
- Remove fallback substring matching that could match malicious URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/byRespect/tracker-hub/security/code-scanning/1
To fix this, the URL should be parsed using the built-in URL constructor (or a trusted library), and the detection for "socket.io" should be performed specifically on the hostname or pathname component (depending on intended logic):
socket.iohosts (likesocket.ioor its known subdomains), then check the parsed URL hostname against a whitelist or exact match./socket.io/(the standard path for socket.io), check the pathname for/socket.ioat the root.useEffecton lines 628-635.try/catcharound URL parsing, as invalid URLs in untrusted input are possible.No new dependencies are required; we can use the standard
URLAPI provided by JavaScript.Suggested fixes powered by Copilot Autofix. Review carefully before merging.