Separate validation evidence gaps from correctness failures - #318
Merged
Conversation
This reverts commit 5c7737c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_tests/min_testsevidence assertionsfinish_coding_taskoutcome_unknownfail-closed behaviorReview follow-ups
The branch was independently reviewed after rebasing onto current
main. The review fixed two duplicateexpected_generationtest fixtures introduced by overlap with #316, renamed a stale test that still described count insufficiency as failed Session validation, and corrected stale architecture/schema documentation. No larger redesign blocker was found.Validation
cargo test -p webcodex-validation— 92 passedcargo test -p webcodex-workflow-session— 165 passedcargo test -p webcodex finish_coding_task_— 25 passedcargo test -p webcodex failure_history_— 8 passedcargo test -p webcodex validation_handoff::cargo_test_assertions::— 4 passedcargo test -p webcodex-tool-contracts— 88 passed; focused post-review schema checks 2 passedcargo test -p webcodex-tool-runtime-contracts— 68 passedcargo test -p webcodex-core validation_identity— 1 passedcargo check --workspace --all-targets— passedcargo check -p webcodex-tool-runtime-contracts --all-targets— passed after reviewer fixture cleanupcargo fmt --all -- --check— passedgit diff --check origin/main...HEAD— passedCloseout dogfood keeps historical failure evidence but reports it non-actionable (
actionable_unexpected_count=0, no unresolved validation failure) instead of hard-blocking the current clean workspace.