Improve apply_patch one-shot matching - #315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strict_matchingwith explicitmatching_mode={first_match,unique,exact_unique}and makeuniquethe real defaultexact_uniquestale-context/concurrency fencing and fail closed on legacystrict_matchingat current Server ingressSafety / authority
outcome_unknowninspect-first behavior are unchangedstrict_matchingremains wire-only compatibility; new Server rejects legacystrict_matchinginstead of silently weakening itValidation
Fresh reviewer validation included:
cargo test -p webcodex-core apply_patch— 25 passedcargo test -p webcodex-runner file_apply_patch— 17 passedcargo test -p webcodex apply_patch— 23 passedcargo fmt --all -- --check— passedgit diff --check— passedProduct-level Go/No-Go for keeping
apply_patchas the default high-frequency model edit path should still be based on fresh sf/dogfood telemetry after deployment, not the deterministic corpus alone.