Govern specialized Plugin and SSH invocations - #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolDefinition/ordinaryToolCallentriesplugin:inspect,plugin:invoke, andplugin:managescopes; shared-key OAuth Plugin opt-in grants inspect+invoke only and direct shared-key baseline remains Plugin-freePermissionEvaluatornot_started/completed/outcome_unknownsemanticsIntegration review
Fresh independent review was performed after #304, #305, #306, and #307 were already on
main. The branch was consciously rebased onto currentmain@373bb7d8; the rebase was clean. In particular, #305 remains authoritative for Runner-side frozen Native Plugin provider contracts and RunnerRegistry response validation, while this PR owns Server-side specialized scope/session/permission/audit governance.The review found one small classification bug:
plugin_tool checkcorrectly requiredplugin:manageand was shell-like, but its authoritative effect/risk was still classified as local execution. Reviewer commit92aeab68now classifiescheckas management while keeping it non-write-like + shell-like; reload remains management/write-like/shell-like and SSH register/remove remain management/write-like/non-shell-like.Fresh validation
cargo check -p webcodex --libpassedcargo check -p webcodex-clipassedcargo fmt --all -- --checkpassedgit diff --checkand staged diff check passedNo full workspace test, deploy/restart, or branch-protection change was performed.