Skip to content

fix: stabilize CI contact timestamp test across timezones #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yw7148 merged 1 commit into from
Apr 1, 2026
Merged

fix: stabilize CI contact timestamp test across timezones #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/test/kotlin/com/youngwon/portfolio/contact/application/ContactCommandServiceTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import org.mockito.Mockito.verify
import org.mockito.Mockito.`when`
import org.mockito.junit.jupiter.MockitoExtension
import java.time.LocalDateTime
import java.time.ZoneId

@ExtendWith(MockitoExtension::class)
class ContactCommandServiceTests {
Expand All @@ -29,14 +30,17 @@ class ContactCommandServiceTests {

@Test
fun `create contact persists contact with next id`() {
val seoulZone = ZoneId.of("Asia/Seoul")
val submission = ContactSubmission(
name = "Youngwon",
email = "youngwon@example.com",
message = "Hello",
)
`when`(contactStore.nextId()).thenReturn(8)
val before = LocalDateTime.now(seoulZone).minusSeconds(1)

val result = service.createContact(submission)
val after = LocalDateTime.now(seoulZone).plusSeconds(1)

assertTrue(result)
verify(contactStore).nextId()
Expand All @@ -48,6 +52,7 @@ class ContactCommandServiceTests {
assertEquals("Youngwon", actual.name)
assertEquals("youngwon@example.com", actual.email)
assertEquals("Hello", actual.message)
assertTrue(actual.contactDate.isBefore(LocalDateTime.now().plusSeconds(1)))
assertFalse(actual.contactDate.isBefore(before))
assertFalse(actual.contactDate.isAfter(after))
}
}
Loading