Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Build server inside Dockerfile #1488

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

copyrights
Copy link
Contributor

resolves #1481

@copyrights
Copy link
Contributor Author

🤔 works on my machine with

podman build \
  --ulimit="nofile=65535:65535" \
  --runtime runc \
  -f ops/docker/jdk11-jammy/Dockerfile \
  --build-context nomnoml="./nomnoml" \
  --build-context vega="./vega" \
  --build-context dbml="./dbml" \
  --build-context wavedrom="./wavedrom" \
  --build-context bytefield="./bytefield" \
  --build-context kroki-src="." \
  server

@ggrossetie
Copy link
Member

Tests related to sockets are failing in the container. Not sure exactly why but it says:

java.net.SocketException: Protocol family unavailable

Might be related to IPv6 not working as excepted with Docker m. Someone suggested to add -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses=true option to the JVM.

You can probably try to add these options on the surefire plugin using: https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine

@copyrights copyrights force-pushed the docker-server-build branch from f1987c6 to 16aff96 Compare March 26, 2023 11:46
@copyrights
Copy link
Contributor Author

copyrights commented Mar 26, 2023

@copyrights copyrights force-pushed the docker-server-build branch 4 times, most recently from 95dc6f7 to 9051072 Compare March 28, 2023 19:42
@copyrights
Copy link
Contributor Author

Ok I just did the test locally with docker buildx bake kroki and it fails at the IPv6 test as well.
Then I changed my /etc/docker/daemon.json to

{
  "ipv6": true,
  "fixed-cidr-v6": "2001:db8:1::/64"
}

and systemctl restart docker. Now the build works fine. Maybe related to actions/runner-images/issues/668

@copyrights
Copy link
Contributor Author

@ggrossetie
Copy link
Member

@copyrights are you still working on it? since we made quite a few changes you will need to rebase on the main branch.

@copyrights
Copy link
Contributor Author

It seems the issue in github actions is closed. But I'll have to rebase to test it. I'll give it a shot.

@copyrights copyrights force-pushed the docker-server-build branch from 3a22690 to f3db2fa Compare August 20, 2023 14:01
@copyrights
Copy link
Contributor Author

Nope, still no IPv6 support inside the github action. Otherwise the rebased version builds fine on systems with IPv6 enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move installLocalDependencies and buildServer to Dockerfile
2 participants