Add DeLTA, FeatureRecord, and harmonisation checks to CI#3
Open
yuqiliang wants to merge 1 commit into
Open
Conversation
The validate workflow previously ran the MOSAIQ linkage check for ISD, ARAUS, and SATP only, leaving DeLTA and two Python validators unguarded. Extend coverage so every built package is checked on push and PR: - run validate_mosaiq.py for DeLTA as well - add check_feature_records.py for ISD/ARAUS/SATP - add validate_schema_harmonisation.py Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
Validate data packagesworkflow previously ran the MOSAIQ linkage check (validate_mosaiq.py) for ISD, ARAUS, and SATP only, and never ran two other validators that already exist in the repo. This extends CI so every built package and validator is exercised on push and PR:validate_mosaiq.py --skip-file-check)check_feature_records.pyfor ISD / ARAUS / SATP (DeLTA has nofeatures.csv, and the script only accepts those three)validate_schema_harmonisation.pyWhy
DeLTA and the two Python validators all pass locally but were not protected by CI, so a regression in any of them could land on
mainunnoticed.Verification
Every new step was run locally before being wired in:
validate_mosaiq.pyDeLTAcheck_feature_records.pyISD / ARAUS / SATPvalidate_schema_harmonisation.pyvalidate.ymlparses as valid YAML (12 steps).Notes for reviewer
.github/workflows/validate.yml(1 file changed, 17 insertions, 1 deletion).🤖 Generated with Claude Code