Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DEF files for specifying library interface #39

Merged
merged 7 commits into from
Feb 25, 2025
Merged

Conversation

yugr
Copy link
Owner

@yugr yugr commented Feb 25, 2025

Supported format is based on Windows DEF files (https://learn.microsoft.com/en-us/cpp/build/reference/module-definition-dot-def-files). Only LIBRARY and EXPORTS tags are supported atm.

@yugr yugr self-assigned this Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (91095d7) to head (b6f5478).

Files with missing lines Patch % Lines
implib-gen.py 87.71% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   88.57%   88.23%   -0.35%     
==========================================
  Files           1        1              
  Lines         394      442      +48     
==========================================
+ Hits          349      390      +41     
- Misses         45       52       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yugr
Copy link
Owner Author

yugr commented Feb 25, 2025

@pg83 does this work for you ? I do not have good tests for this functionality.

@pg83
Copy link

pg83 commented Feb 25, 2025

@pg83 does this work for you ? I do not have good tests for this functionality.

year, it works, thanx a lot!

@yugr yugr merged commit 4eab9f5 into master Feb 25, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants