Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing custom dlsym() replacement. #17

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

Artem-B
Copy link
Contributor

@Artem-B Artem-B commented Jul 29, 2022

It's useful when one needs to provide special-case handling of symbols
(e.g. providea an error-returning stub if a symbol is missing).

Copy link
Owner

@yugr yugr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #17 (7ce4c87) into master (1ba2f31) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   91.64%   91.69%   +0.04%     
==========================================
  Files           1        1              
  Lines         347      349       +2     
==========================================
+ Hits          318      320       +2     
  Misses         29       29              
Impacted Files Coverage Δ
implib-gen.py 91.69% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba2f31...7ce4c87. Read the comment docs.

@yugr
Copy link
Owner

yugr commented Jul 30, 2022

@Artem-B I know that Pylint warnings may seem useless but could you still fix this long line?

implib-gen.py:333:0: C0301: Line too long (102/100) (line-too-long)

It's useful when one needs to provide special-case handling of symbols
(e.g. providea an error-returning stub if a symbol is missing).
@Artem-B
Copy link
Contributor Author

Artem-B commented Jul 30, 2022

@Artem-B I know that Pylint warnings may seem useless but could you still fix this long line?

implib-gen.py:333:0: C0301: Line too long (102/100) (line-too-long)

Done.

@yugr yugr merged commit bbca01e into yugr:master Jul 30, 2022
@Artem-B Artem-B deleted the dlsym-callback branch July 30, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants