[PLAT-16596] Expose CLI parameters for activation frequency from EarlyOOM #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add testing done, and a description for why this is necessary? |
| @@ -31,6 +31,10 @@ typedef struct { | |||
| regex_t* ignore_regex; | |||
| /* memory report interval, in milliseconds */ | |||
| int report_interval_ms; | |||
| /* minimal interval between checks */ | |||
There was a problem hiding this comment.
is there valid values for this for min and max?
| @@ -147,7 +149,7 @@ int main(int argc, char* argv[]) | |||
| meminfo_t m = parse_meminfo(); | |||
|
|
|||
| int c; | |||
| const char* short_opt = "m:s:M:S:kingN:dvr:ph"; | |||
| const char* short_opt = "l:m:s:M:S:kingN:dvr:ph"; | |||
There was a problem hiding this comment.
so we are using one cli switch to send in 2 values?
What if we want to override only one?
|
Can you also add tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.