chore(manifest): tag UnusedAttribute perm flags with tools:targetApi#509
Merged
Conversation
## Priority 5 BLUETOOTH_SCAN's `usesPermissionFlags="neverForLocation"` is an API 31+ attribute, and NEARBY_WIFI_DEVICES' matching flag is API 33+. Current minSdk is 28, so lint flagged both as UnusedAttribute. The attributes are still correct on the devices that honor them — add `tools:targetApi` hints so lint knows the version gate and stops warning. ./gradlew lint + testFullDebugUnitTest green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority 5 — Refactor / quality
Two manifest warnings were firing on every lint run:
Current minSdk is 28, so lint saw these as unused. Added matching `tools:targetApi` markers so the attributes stay but the warnings go away.
Test plan