Add metrics #38
Merged
Add metrics #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalmau
approved these changes
Feb 28, 2021
meldebot/mel/poll.py
Outdated
| question = "\n".join(old_message.split("\n")[:-4]) | ||
|
|
||
| mel_votes = [ | ||
| (f'@{row["username"]}', row["vote"]) for row in votes if row["vote"] > 0 |
There was a problem hiding this comment.
Just a minor note: if a user doesn't have @username it will use the public name
There was a problem hiding this comment.
Same behaviour as before 👍
I've added the missing docstring to the get_username method.
Co-authored-by: Gerard Dalmau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case
Close #16
Observations
Added dependencies:
Using PostgreSQL as the metrics database (at least for now)
This also unblocks us for #9 as we can now update the message and store the content.