-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applied @dirkf's patches for nsig extraction on youtube #32891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the extra change. I thought there was also a diff against the original patch but apparently not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed formatting.
Thanks for helping out! The tests all work. You might like to pull the updated version and try running |
LGTM |
* https://github.com/ytdl-org/youtube-dl: [Youtube] Fix nsig extraction for player 20dfca59 (ytdl-org#32891)
[Youtube] Fix nsig extraction for player 20dfca59 (ytdl-org#32891)
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixes nsig extraction for youtube
See #32885