-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telewebion] fix extraction #32634
[telewebion] fix extraction #32634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I've made a few comments. Please check those and the results of the CI tests that I enabled.
Co-authored-by: dirkf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes committed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a useful tweak and with any luck the right CI tests will run now.
'info_dict': { | ||
'id': '1263668', | ||
'id': '0x1b3139c', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly, you can replace the hexadecimal ID with its decimal equivalent (28513180).
Resolves #5135 (comment). |
* https://github.com/ytdl-org/youtube-dl: [telewebion] Fix extraction (ytdl-org#32634)
And thanks again! |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
This pull request fixes the problem of downloading videos from telewebion and uses its new api.