Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telewebion] fix extraction #32634

Merged
merged 5 commits into from
Dec 2, 2023
Merged

[telewebion] fix extraction #32634

merged 5 commits into from
Dec 2, 2023

Conversation

mimvahedi
Copy link
Contributor

@mimvahedi mimvahedi commented Nov 11, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

This pull request fixes the problem of downloading videos from telewebion and uses its new api.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I've made a few comments. Please check those and the results of the CI tests that I enabled.

youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@mimvahedi mimvahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes committed

@mimvahedi mimvahedi requested a review from dirkf November 27, 2023 15:37
mimvahedi

This comment was marked as spam.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a useful tweak and with any luck the right CI tests will run now.

'info_dict': {
'id': '1263668',
'id': '0x1b3139c',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, you can replace the hexadecimal ID with its decimal equivalent (28513180).

youtube_dl/extractor/telewebion.py Outdated Show resolved Hide resolved
@dirkf
Copy link
Contributor

dirkf commented Dec 2, 2023

Resolves #5135 (comment).

@dirkf dirkf merged commit c62936a into ytdl-org:master Dec 2, 2023
14 checks passed
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Dec 2, 2023
@dirkf
Copy link
Contributor

dirkf commented Dec 6, 2023

And thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants