Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test on GHA (⏰ wait for #238) #229

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neutrinoceros
Copy link
Member

start migrating tests to GitHub Actions
So far I couldn't get data-requiring tests to not skip, but I think this is symptom of a bigger issue with the requires_ds decorator that may not work at all with pytest.
I'll try to make this more useful before I open for review

@neutrinoceros
Copy link
Member Author

I finally reported the issue with requires_ds upstream: yt-project/yt#4692

@neutrinoceros
Copy link
Member Author

After diving in I realised that requires_ds is in fact pretty deeply rooted into yt's answer testing framework, which is not pytest compatible. However, I also reckon that yt_astro's tests seem only written around that framework out of convenience: the "answer objects" that are produced are very small (single floats, or very small numpy arrays), so it should be relatively easy to rewrite them and get rid of nose. I'll try to have a go at it tomorrow. Meanwhile, let's see if it's possible to add Python 3.12 to the test matrix here and get rid of #232

@neutrinoceros neutrinoceros force-pushed the test_with_gha branch 4 times, most recently from 757f768 to de1a04e Compare October 10, 2023 12:49
@neutrinoceros neutrinoceros force-pushed the test_with_gha branch 3 times, most recently from e174577 to 4115397 Compare October 10, 2023 18:09
@neutrinoceros
Copy link
Member Author

What's not figured out yet is how to run mpi tests: I migrated them to pytest but I couldn't actually run them yet (maybe I'm hitting a deadlock).

@neutrinoceros
Copy link
Member Author

I guess splitting this work over two pull requests (migration to pytest then migration to GHA) would help with making sure I'm not breaking anything.

@neutrinoceros neutrinoceros changed the title TST: test on GHA TST: test on GHA (wait for #238) Oct 11, 2023
@neutrinoceros neutrinoceros changed the title TST: test on GHA (wait for #238) TST: test on GHA (⏰ wait for #238) Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant