-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: test on GHA (⏰ wait for #238) #229
base: main
Are you sure you want to change the base?
Conversation
I finally reported the issue with |
After diving in I realised that |
757f768
to
de1a04e
Compare
e174577
to
4115397
Compare
What's not figured out yet is how to run mpi tests: I migrated them to pytest but I couldn't actually run them yet (maybe I'm hitting a deadlock). |
I guess splitting this work over two pull requests (migration to pytest then migration to GHA) would help with making sure I'm not breaking anything. |
4115397
to
4c2635a
Compare
4c2635a
to
1c73485
Compare
start migrating tests to GitHub Actions
So far I couldn't get data-requiring tests to not skip, but I think this is symptom of a bigger issue with the
requires_ds
decorator that may not work at all with pytest.I'll try to make this more useful before I open for review