-
Notifications
You must be signed in to change notification settings - Fork 10
fix: graceful MCP degradation in Pi extension + ask-before-install skill wording #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
500da33
fix: ask before installing missing You.com MCP servers in skills
EdwardIrby 40c3b79
fix: resolve overlapping steps and inaccurate auth reference in you-d…
EdwardIrby b6e6e01
feat: identify You.com MCP adapter config via static host context
EdwardIrby 24e823a
fix: clarify You.com MCP setup guidance
EdwardIrby a84b4ca
refactor: remove redundant includeTool filter, test against real MCP …
EdwardIrby cc49068
fix: pass MCP content blocks directly to model instead of JSON-wrapping
EdwardIrby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] HOST_CONTEXT lists you-search under the wrong URL and auth requirement
The third bullet of
HOST_CONTEXTstates`you-search` / `you-contents` / `you-research` (YDC_API_KEY or OAuth): https://api.you.com/mcp, butSERVER_CONFIGSregistersyou-searchexclusively fromhttps://api.you.com/mcp?profile=freewithauthenticated: false, and the base-URL config explicitly excludes it viaincludeTool: (tool) => tool.name !== 'you-search' && tool.name !== 'you-finance'. Soyou-searchappears twice in the injected system prompt with conflicting information: the first bullet correctly says free/no-auth at the profile=free URL, while this bullet incorrectly says YDC_API_KEY/OAuth at the base URL. This is guidance text only, actual tool registration is correct, but it can mislead the agent into telling users they needYDC_API_KEYforyou-searchwhen it is keyless. Dropyou-searchfrom the third bullet so it lists onlyyou-contents/you-research.