feat(redmine): Implement list_project_statuses tool and integrate (GH-53) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This commit introduces the 'list_project_statuses' tool, enabling the retrieval of available issue statuses for a specific project and tracker within Redmine, and integrates it into the MCP server.\n\nKey implementations include:\n- Definition of PROJECT_LIST_STATUSES_TOOL in 'src/tools/projects.ts'.\n- Handler logic in 'src/handlers/projects.ts' to fetch issues and extract 'allowed_statuses', with dependency injection for the formatter.\n- Type extensions for RedmineIssue (adding 'allowed_statuses') in 'src/lib/types/issues/types.ts'.\n- Zod schema updates for RedmineIssue (adding 'allowed_statuses') in 'src/lib/types/issues/schema.ts', along with minor adjustments to other fields for nullability/optionality.\n- Addition of 'formatAllowedStatuses' function in 'src/formatters/projects.ts'.\n- Updates to 'src/handlers/index.ts' to pass the formatter to 'createProjectsHandlers' and to dynamically build the server's tool list.\n- Export of PROJECT_LIST_STATUSES_TOOL in 'src/tools/index.ts'.\n\nThis functionality addresses the requirements outlined in issue #53 by providing a standardized way for the MCP server to interact with Redmine for status information.\n\nNote: The corresponding Jest test file (src/handlers/__tests__/projects/list_statuses.test.ts) mentioned in the reference document has not been created in this commit and needs to be addressed separately.
- Fix TypeScript compilation errors for Jest Mock type definitions - Change Mock<any, any> to Mock<any> to match Jest's type signature - Add explicit mockImplementation in beforeEach to ensure mock function behavior - Clear and reset mocks properly between test runs - All list_project_statuses tests now pass (10/10) Resolves issue where mock function returned undefined instead of expected string output. Test coverage remains stable at 40.25% with improved test reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the 'list_project_statuses' tool, enabling the retrieval of available issue statuses for a specific project and tracker within Redmine, and integrates it into the MCP server. This addresses issue #53.
Key Changes:
src/tools/projects.ts):PROJECT_LIST_STATUSES_TOOLdefinition.src/handlers/projects.ts):list_project_statuseshandler to fetch a representative issue and retrieve itsallowed_statuses.formatAllowedStatusesFn) to improve testability, as per the reference document.src/lib/types/issues/):RedmineIssueinterface intypes.tsto include the optionalallowed_statusesproperty.RedmineIssueSchemainschema.tswith the schema forallowed_statusesand adjusted nullability/optionality for fields likedue_date,description,start_date, etc., based on the reference document and typical Redmine API behavior.src/formatters/projects.ts):formatAllowedStatusesfunction to present the status list in a user-friendly format.src/handlers/index.ts&src/tools/index.ts):src/handlers/index.tsto pass theformatAllowedStatusesformatter tocreateProjectsHandlers.src/handlers/index.tsto dynamically build the server's tool list from thetoolsmodule, ensuring automatic inclusion of new tools.PROJECT_LIST_STATUSES_TOOLfromsrc/tools/index.ts.Note on Testing:
The Jest test file
src/handlers/__tests__/projects/list_statuses.test.ts, mentioned in the reference documentation as successfully passing, has not been created or included in this commit due to its absence in the provided sandbox environment. This will need to be addressed in a follow-up task to ensure full test coverage for the new functionality.Related Issue: Closes #53