Reworked the way menu labels are built #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yann-eugone
commented
Jan 31, 2019
yann-eugone
commented
- use admin translation domain as extra parameter everywhere (see issue Transition item is not translated using the admin translation domain #7)
- fill label translator strategy type for transitions (see issue Transition item is translated with a "leading" underscore #8)
… as extra parameter everywhere + fill label translator strategy type for transitions
|
Subscribing. Why tests are failing? |
|
Composer memory limit issue, didn't had time to investigate yet |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.