Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.x #26

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Allow PHP 8.x #26

merged 2 commits into from
Apr 9, 2021

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 3, 2021

Support for PHP < 7.3 is also dropped since it was already dropped from sonata-project/admin-bundle 3.x.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #26 (c8d2fa1) into 0.4.x (0897dd9) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.4.x      #26      +/-   ##
============================================
+ Coverage     90.96%   91.02%   +0.05%     
+ Complexity       46       44       -2     
============================================
  Files             2        2              
  Lines           155      156       +1     
============================================
+ Hits            141      142       +1     
  Misses           14       14              
Impacted Files Coverage Δ Complexity Δ
src/Admin/Extension/WorkflowExtension.php 98.83% <0.00%> (+0.01%) 28.00% <0.00%> (-1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0897dd9...c8d2fa1. Read the comment docs.

@phansys phansys marked this pull request as ready for review April 3, 2021 03:54
@yann-eugone yann-eugone merged commit 5f0f6bd into yokai-php:0.4.x Apr 9, 2021
@yann-eugone
Copy link
Contributor

Thank you @phansys :)

@phansys phansys deleted the php-8.x branch April 9, 2021 16:52
@yann-eugone
Copy link
Contributor

Released in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants