Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate from spec version 1.70.0 #167

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Generate from spec version 1.70.0 #167

merged 2 commits into from
Jun 27, 2024

Conversation

bradymholt
Copy link
Member

@bradymholt bradymholt commented Jun 25, 2024

Generate based on server spec version 1.70.0.

  • Adds goal_needs_whole_amount field to category model responses.
  • Adds ability to update payee

@bradymholt bradymholt requested a review from joshmenden June 25, 2024 22:18
@joshmenden
Copy link

joshmenden commented Jun 27, 2024

Nice this looks good. I ran a few smoketests with the dependency pointed at this branch and everything looks good.

One thought I have for future reference. When I tried to run this generator in this repo a month ago or so I ran into this issue: OpenAPITools/openapi-generator#18746

Which has since been resolved. I was running with version 7.5.0 and you here are using 7.6.0 with the patch.

It made me think we should use docker for the API generation script, since we can then hard-code the generator version into the docker image. Something like they have in their docs

docker run --rm \
    -v $PWD:/local openapitools/openapi-generator-cli generate \
    -i /local/petstore.yaml \
    -g go \
    -o /local/out/go

Then we wouldn't be dependent on whatever latest version somebody gets when the do brew install and can manually up the version as we have time.

I can create an issue to tackle this down the road.

@@ -3,7 +3,9 @@
## Setup

- Install dependencies: `npm install`
- Generate client based on latest spec: `npm run generate`
- Generate latest client based on OpenAPI spec:
- Install [OpenAPI Generator](https://openapi-generator.tech/), for macOS: `brew install openapi-generator`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bradymholt
Copy link
Member Author

Thanks for review.

@bradymholt bradymholt merged commit 0160175 into main Jun 27, 2024
3 checks passed
@bradymholt bradymholt deleted the gen-1.70.0 branch June 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants