Skip to content
This repository was archived by the owner on Jul 1, 2022. It is now read-only.

Fix visibility checks for global alerts.#2382

Open
duozersk wants to merge 1 commit into
ymcatwincities:9.x-2.xfrom
duozersk:patch-1
Open

Fix visibility checks for global alerts.#2382
duozersk wants to merge 1 commit into
ymcatwincities:9.x-2.xfrom
duozersk:patch-1

Conversation

@duozersk
Copy link
Copy Markdown
Contributor

@duozersk duozersk commented Jan 20, 2021

If alert is global then the $pages array ends up as [0 => ""] and can't be empty after the preg_split function.

Steps to review:

  • create new alert with no visibility limitations
  • verify it is visible on frontpage and several other pages

Conversation about this in Slack https://openy.slack.com/archives/C6G4ZTLVC/p1611132731028300

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Copy Markdown
Contributor

podarok commented Jan 20, 2021

ok to test

@bjwilkins
Copy link
Copy Markdown
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3064/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3064/

@bjwilkins
Copy link
Copy Markdown
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3064/

@podarok podarok changed the base branch from 9.x-2.x to 9.x-2.x-af4 January 20, 2021 08:51
@bjwilkins
Copy link
Copy Markdown
Collaborator

Open Y Complete profile installed at http://openy.cibox.tools/build3064/

@podarok podarok added Backporting Requests to backport features from YMCAs to the Open Y Distribution Status: Under discussion There is discussion in progress. More information to be provided soon Type: Bug Bug. Something is not working as intended. PR: DO NOT MERGE Work in Progress or something not to be merged at all labels Jan 20, 2021
@podarok podarok closed this Feb 8, 2021
@podarok podarok deleted the branch ymcatwincities:9.x-2.x February 8, 2021 11:37
@podarok podarok reopened this Feb 8, 2021
@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Copy Markdown
Contributor

podarok commented Feb 8, 2021

that automation thing is sometimes so overautomated....

@duozersk
Copy link
Copy Markdown
Contributor Author

Well... somehow after some changes this PR now contains more commits and more changes and doesn't apply to the place where it was applied without issues before... frustrating :(

@duozersk duozersk changed the base branch from 9.x-2.x-af4 to 9.x-2.x February 20, 2021 03:38
@duozersk
Copy link
Copy Markdown
Contributor Author

Fixed "frustration" by changing the base branch ^^

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

5 similar comments
@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@bjwilkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Backporting Requests to backport features from YMCAs to the Open Y Distribution PR: DO NOT MERGE Work in Progress or something not to be merged at all Status: Under discussion There is discussion in progress. More information to be provided soon Type: Bug Bug. Something is not working as intended.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants