Mark as yk_outline functions which we don't want to trace.
#130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edd's recent analysis suggests that we often end up recording blocks in these functions, even though neither is appropriate for a trace.
Contributor
|
Should we wait for the other change to be benchmarked before we merge this, so we can see the impacts in isolation? |
Contributor
Author
|
The other PR won't be benchmarked until the yk PR is merged, so it's safe to do this one first IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edd's recent analysis suggests that we often end up recording blocks in these functions, even though neither is appropriate for a trace.