Split setnodevector.
#126
Merged
Split setnodevector.
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common case, by far, is `size == 0` so this function was being outlined mostly for no good reason. This commit splits it into two: the common case can be inlined by yk, with the uncommon case leading to a `call`. This leads to a small, but just about measurable speed up, on some benchmarks (including ~3% on Richards).
Contributor
|
Nice-la. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common case, by far, is
size == 0so this function was being outlined mostly for no good reason. This commit splits it into two: the common case can be inlined by yk, with the uncommon case leading to acall.This leads to a small, but just about measurable speed up, on some benchmarks (including ~3% on Richards).