Use the yklua-tests repo. #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we had a submodule for the openresty tests and a duplicated run.sh. This removes the submodule and the duplicated runner and switches instead to using our yklua-tests repo. While we are here, also test unserialised compilation. Note: serialised compilation still takes a long time to test on account of tak.lua being so very slow.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Contributor
Author
|
The reason this timed out appears to be because the currently in-tree runner runs each test once, whereas the one in the yklua-tests repo runs things 10 times. (Running tak.lua 10 times takes about 3 hours now) I'm going to make a PR on the yklua-tests repo to only run things once for now and then we are at parity with what we did before. |
Contributor
Author
|
With luck this should merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had a submodule for the openresty tests and a duplicated run.sh. This removes the submodule and the duplicated runner and switches instead to using our yklua-tests repo.
While we are here, also test unserialised compilation.
Note: serialised compilation still takes a long time to test on account of tak.lua being so very slow.