Use atomic operations on the thread tracing state. #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Dec 9, 2025
| Instruction *ThreadTracingState = | ||
| LoadInst *ThreadTracingState = | ||
| Builder.CreateLoad(I8Ty, ThreadTracingTL); | ||
| ThreadTracingState->setAtomic(llvm::AtomicOrdering::Acquire); |
There was a problem hiding this comment.
This is an atomic int I think? If so, it should be Ordering::Relaxed IMHO.
This is more obviously safe.
vext01
force-pushed
the
lightweight-swt-atomic
branch
from
6321aa3 to
5123de2
Compare
Author
|
Fixed in a force push. For whatever reason, what the rest of the world calls "relaxed", they call "monotonic": Similar fixes will need to be applied to they yk side, which I will apply now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more obviously safe.
yk-side PR to follow.