Revert shimming. #289
Merged
Revert shimming. #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vext01
force-pushed
the
revert-shimming
branch
from
1f9a023 to
3ae859a
Compare
Author
|
Force pushed formatting and updated the yk PR too. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
FWIW, I did not spot any changes when I did "compare", but I thought it might be a GitHub quirk. But I think you might have forgotten to commit your actual formatting changes! |
… not tracing." This reverts commit 0fa3c31. This code was an earlier experiment that didn't work as expected. It's effectively dead code, since it's gated behind a flag not currently used in yk-config.
vext01
force-pushed
the
revert-shimming
branch
from
3ae859a to
b01bf8e
Compare
Author
|
Force pushed the fix. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0fa3c31.
This code was an earlier experiment that didn't work as expected. It's effectively dead code, since it's gated behind a flag not currently used in yk-config.
The shimming branch contained two other commits that I'm OK with keeping:
yk_outline(since they can't be traced).yk_outlinefunctions that are not clones, update their callees to call optimised clones where possible (because they (the callers) also, can't be traced).