Tweak memcpy optimisation
#2003
Merged
+34
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised recently that my editor sometimes goes wonky and changes comment width. This commit rewrites all comments in this file to the most common width (100 chars).
libc's `memcpy` gives `memcpy(x, x, ...)` undefined behaviour, but LLVM's `memcpy` gives this defined behaviour. The outcome from our perspective is the same in either case (we can remove the `memcpy`), but the reason is different. While here, we can generalise the "equivalence" check to whenever the SSA variables are the same, even if they're not constant.
Fidget-Spinner
approved these changes
Dec 28, 2025
Contributor
|
Do you want to squash? |
Contributor
Author
|
I think these are best left as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing a formatting mistake with comments (mea culpa!), the main point of this PR is to slightly extend the
memcpyoptimisation and change the reasoning given (8a9a8d5).