Light(er)weight tracing. #1957
Merged
Light(er)weight tracing. #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vext01
commented
Dec 3, 2025
| /// What kind of tracing (if any!) is this thread undertaking? | ||
| fn tracing_kind() -> IsTracing { | ||
| THREAD_IS_TRACING.with(|x| x.load(Ordering::Relaxed)) | ||
| let raw = &raw mut __yk_thread_tracing_state; |
Contributor
Author
There was a problem hiding this comment.
I will try again (in a follow up PR) to use an atomic here, thus avoiding the need for &raw, but as you can see, this PR is already big enough.
vext01
force-pushed
the
lightweight-swt
branch
from
3439471 to
801e705
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Looks like a simple Clippy fix. |
vext01
force-pushed
the
lightweight-swt
branch
from
801e705 to
e8172db
Compare
Contributor
Author
|
Force pushed a fix. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Light(er)weight tracing.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vext01
force-pushed
the
lightweight-swt
branch
from
e8172db to
a1cbfc7
Compare
Contributor
Author
|
Not sure what happened there. Re-synced ykllvm anyway. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vext01
force-pushed
the
lightweight-swt
branch
from
a1cbfc7 to
91b429b
Compare
Contributor
Author
|
Force pushed more clippy fixes. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vext01
force-pushed
the
lightweight-swt
branch
from
91b429b to
01e0e7c
Compare
Contributor
Author
|
Fifth time lucky? |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Decide if we the current thread is tracing inline, in the interpreter, rather than calling off to Rust in every block. The Rust side now defines the thread local shared with LLVM IR generated by our software tracing pass. Also many fixes to make this work, the most important of which allows traces to retrieve live variables from registers (and not just spill slots). A large comment explains.
vext01
force-pushed
the
lightweight-swt
branch
from
01e0e7c to
e0f8258
Compare
Contributor
Author
|
Force pushed the fix for the hanging test. We were worried about the potential performance hit from saving/restoring those 6 registers. This is what I measured on b15: I think that's still a good starting point for the other optimisations we've planned. Would you agree? |
Contributor
Author
|
(those results are from 5 process executions) |
Contributor
|
LGTM! I take it I can now merge this? |
Contributor
Author
|
Go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: ykjit/ykllvm#291
Decide if we the current thread is tracing inline, in the interpreter, rather than calling off to Rust in every block.
The Rust side now defines the thread local shared with LLVM IR generated by our software tracing pass.
Also many fixes to make this work.