Pull in a test the new yk_indirect_inline attribute.
#1952
Merged
+97
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vext01
commented
Nov 26, 2025
| debug_assert!(!inst.is_debug_call(self.aot_mod)); | ||
|
|
||
| let jit_callop = self.handle_operand(callop)?; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Force pushed a fix for this.
vext01
force-pushed
the
yk-indirect-outline-attr
branch
2 times, most recently
from
37b2338 to
892a80e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This exposes a deficiency in the jitc_yk trace builder, which I've hacked around for now. We will get an assertion failure if/when this deficiency arises, but hopefully j2 has a way to handle it properly.
vext01
force-pushed
the
yk-indirect-outline-attr
branch
from
892a80e to
864e01d
Compare
Contributor
Author
|
Force pushed a fix for the test in debug mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ykjit/ykllvm#290
This exposes a deficiency in the jitc_yk trace builder, which I've hacked around for now.
We will get an assertion failure if/when this deficiency arises, but hopefully j2 has a way to handle it properly.