Only optimise load/bin/store for consts. #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We *could* do non-constants too, but the register allocator currently isn't really set up for that. Since this is probably a small win, just don't try and optimise it.
Contributor
|
LGTM. Does this one need merging first? ykjit/yklua#123 |
Contributor
Author
|
On the contrary, what's in this PR is necessary for the yklua PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could do non-constants too, but the register allocator currently isn't really set up for that. Since this is probably a small win, just don't try and optimise it.
This stops us hitting a
todothat is stopping yklua (and friends) PRs from merging.