Allow writing of 64-bit constant ints. #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Looks like this also depends on ykjit/yklua#120? Now that that is merged I will try again. Or do we need to wait for ykjit/yk-benchmarks#21 first? Edit: Re-reading your offline comment I see you did say we needed to wait. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
A recent yklua change means that we do now see this case in the wild.
Contributor
Author
|
This bit hadn't occurred to me: this PR needs the new yklua for buildbot.sh. Fixed in the force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent yklua change means that we do now see this case in the wild.