Add --file option to specify custom config files. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -f/--file CLI flag to load alternative haste configuration files. Defaults to haste.toml when not specified. This is useful when running multiple benchmarks with different configurations.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying custom configuration files via a -f/--file CLI option, enabling users to run benchmarks with different configurations without modifying the default haste.toml file.
Key Changes:
- Added
--fileCLI flag to specify custom config file paths - Updated
Appstruct to store and use the config file path - Added test coverage for default config path and config file loading
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
I have an almost identical diff that I've been using locally :) The only comment I have is |
Contributor
Author
Renamed 👉 af48516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -f/--file CLI flag to load alternative haste configuration files. Defaults to haste.toml when not specified. This is useful when running multiple benchmarks with different configurations.