ci: switch off the post-merge review-summary request on buzz - #138
Merged
Conversation
A merged PR's close no longer asks Alex for a review summary or holds the
room open for it. buzz-pr-mirror.yml gains POST_MERGE_SUMMARY, shipped
"off" and validated to be exactly on|off before any write; with it off a
merged PR takes the not-merged close path: one mention-free notice
("✅ **Merged** — archiving this channel."), the cross-channel
annotations, the archive, and the close marker. Nobody is p-tagged.
The switch governs only whether a NEW request is made. A room that
already holds one — a `summary-requested:` marker, or a request this CI
identity published under a lost marker write — is still finished by the
existing grace-and-settle hold, because the p-tag is out and an archive
now would refuse the summary it asked for. The off path therefore keeps
request_summary's full-history probe before its fence. The mechanism is
kept intact and tested under `on`, so flipping the value back restores
it without a rewrite.
pr-mirror-close.test.sh asserts the shipped value is "off", runs the
request scenarios under an explicit `on`, and adds off-path scenarios
for the event close, the sweep close, an already-published request
honoured, the forced re-close inside the convergence loop, and an
invalid switch value (332 → 375 assertions). Each of three mutations —
value flipped to on, gate removed, off-path probe removed — fails the
suite. docs/pr-auto-merge.md and the buzz-pr-auto-merge.yml comments
that described the hold now say the channel archives on the merge's own
closed event. Velvet's mirror keeps the request on; the two differ here
on purpose.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Junchao Yan <yjc801@gmail.com>
github-actions
Bot
added
the
approved-manual-merge
github-actions
Bot
removed
the
approved-manual-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A merged PR's close no longer asks Alex for a review summary or holds the room open for it.
buzz-pr-mirror.ymlgains aPOST_MERGE_SUMMARYenv value, shipped"off"and validated to be exactlyonoroffbefore any write. With it off, a merged PR takes the same close path as a PR closed without a merge: one mention-free notice (✅ **Merged** — archiving this channel.), the cross-channel annotations, the archive, and the close marker. Nobody is p-tagged.Why
The owner asked for the post-merge summary to be disabled on this repo. Velvet's mirror keeps the request on; the two mirrors now differ here on purpose, so a future sync should not carry this back.
What a reviewer should know
summary-requested:close marker or a request this CI identity published under a lost marker write, is still finished by the existing grace-and-settle hold. The p-tag is out and a summary may be mid-turn, and an archive now would refuse it. So the off path keepsrequest_summary's full-history probe ahead of its fence, and rooms in that state drain within one grace window of the flip.on. Flipping the value back restores it without a rewrite.pr-mirror-close.test.shasserts the shipped value is"off", runs the request scenarios under an explicitPOST_MERGE_SUMMARY_INPUT=on, and adds off-path scenarios: the event close, the sweep close, an already-published request honoured rather than archived over, the forced re-close inside the convergence loop, and an invalid switch value refused. 332 → 375 assertions. Three mutations each fail the suite: value flipped toon, the gate removed (always ask), and the off-path probe removed.docs/pr-auto-merge.mdand the comments inbuzz-pr-auto-merge.ymlthat described the hold now say the channel archives on the merge's ownclosedevent. The best-effort post-merge alert into the PR channel is unchanged in behaviour; its comment now states the race honestly.Verification
just auto-merge-checkgreen (all lanes, including actionlint on both workflows).🤖 Generated with Claude Code