Allow configuration of checkbox ActiveField label class name#203
Open
antichris wants to merge 1 commit intoyiisoft:masterfrom
Open
Allow configuration of checkbox ActiveField label class name#203antichris wants to merge 1 commit intoyiisoft:masterfrom
antichris wants to merge 1 commit intoyiisoft:masterfrom
Conversation
Also add test cases verifying this functionality. And the missing trailing newline at the end of the test file.
Member
|
Since it's there from the very beginning mikehaertl/yii2@7364249#diff-37ce2b0674ccb8129c6a33875aec0bbfR177. @mikehaertl do you remember why the class is nulled in case of checkboxes and radios? |
Contributor
|
The examples in the BS3 docs have no class set for checkbox labels. But if you don't null it, you inherit the default class But I agree that there's a problem if you want to explicitely set a class. I'm just not sure about a proper fix. |
Author
|
I am well aware that this can actually be worked around by passing the class name(s) in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For no apparent reason (not apparent to me, that is) the author of
ActiveFielddecided, that theclassattribute of a checkbox label should not be configurable. I beg to differ.BC could get broken for those relying on
classbeing ignored inlabelOptions(no idea why would anyone want to do that, though).I figured that opening an issue for discussion would take more time then just creating a PR that fixes the problem, since an existing pull request can be merged or rejected any time, while an issue would require someone to create a PR for it to be resolved anyway.