feat: add configurable verbosity for FAISS/HNSW C++ output #197
+206
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes yichuan-w#187 Adds --verbose/-v and --quiet/-q flags to control C++ backend output: - Default behavior is quiet (suppresses C++ logs) - Use --verbose to show detailed FAISS/HNSW logs for debugging Implementation: - Add suppress_cpp_output() context manager that redirects fd 1/2 - Add global verbosity flags to main argument parser - Apply suppression to build, search, and ask commands - Add comprehensive tests for the new functionality Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--verbose/-vand--quiet/-qflags to control C++ backend output--verboseto show detailed logs for debuggingFixes #187
Test plan
tests/test_cli_verbosity.py