feat: Add warmup functionality to reduce search latency #195
+380
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add enable_warmup parameter to HNSW and DiskANN embedding servers - Implement warmup() method on LeannSearcher for manual pre-warming - Auto-warmup option during LeannSearcher initialization (enable_warmup=True) - Pre-load embedding model at server startup to avoid cold-start latency - Add comprehensive tests for warmup functionality Fixes yichuan-w#177 (search recompute latency) Fixes yichuan-w#159 (warmup strategy)
Owner
|
Thanks, this is a known issue for a long time, we will look into that!! cc @andylizf , and can you fix the lint error here? |
- Remove unused imports (tempfile, Path, MagicMock) - Fix import order (stdlib before third-party) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Author
|
The macOS-13 CI jobs show as 'cancelled' rather than 'failed' - this appears to be a GitHub Actions runner issue, not a code problem. All other builds (macos-14, macos-15, ubuntu) passed successfully. Could you please re-run the cancelled macOS-13 jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enable_warmupparameter to HNSW and DiskANN embedding servers to pre-load model at startupwarmup()method onLeannSearcherfor manual pre-warming before first searchLeannSearcherinitialization (enable_warmup=True)Test Plan
tests/test_warmup.pyFixes #177
Fixes #159