Y_FAIL_S in the TDistributedTransaction constructor #27103

Alek5andr-Kotov · 2025-10-18T08:46:22Z

Changelog entry

Replaced it with AFL_ENSURE. During the initialization of the PQ tablet, the Kind field is checked for the transaction.

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

...

github-actions · 2025-10-18T08:49:13Z

🟢 2025-10-18 08:49:13 UTC The validation of the Pull Request description is successful.

github-actions · 2025-10-18T08:50:06Z

⚪ 2025-10-18 08:50:05 UTC Pre-commit check linux-x86_64-release-asan for c24229b has started.
⚪ 2025-10-18 08:50:19 UTC Artifacts will be uploaded here
⚪ 2025-10-18 08:54:05 UTC ya make is running...
🔴 2025-10-18 08:57:44 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-10-18T08:50:19Z

⚪ 2025-10-18 08:50:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for c24229b has started.
⚪ 2025-10-18 08:50:33 UTC Artifacts will be uploaded here
⚪ 2025-10-18 08:54:05 UTC ya make is running...
🔴 2025-10-18 08:56:57 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-10-20T10:37:31Z

⚪ 2025-10-20 10:37:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 949613e has started.
⚪ 2025-10-20 10:37:44 UTC Artifacts will be uploaded here
⚪ 2025-10-20 10:41:15 UTC ya make is running...
🟡 2025-10-20 12:04:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31358	29943	0	13	1374	28

⚪ 2025-10-20 12:05:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-20 12:32:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
748 (only retried tests)	727	0	1	0	20

⚪ 2025-10-20 12:32:24 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-20 12:57:15 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
559 (only retried tests)	539	0	0	0	20

🟢 2025-10-20 12:57:18 UTC Build successful.
🟢 2025-10-20 12:57:37 UTC ydbd size 2.3 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `55d530d`	merge: `949613e`	diff	diff %
ydbd size	2 426 245 704 Bytes	2 426 246 824 Bytes	+1.1 KiB	+0.000%
ydbd stripped size	516 333 864 Bytes	516 334 376 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-20T10:40:06Z

⚪ 2025-10-20 10:40:05 UTC Pre-commit check linux-x86_64-release-asan for 949613e has started.
⚪ 2025-10-20 10:40:18 UTC Artifacts will be uploaded here
⚪ 2025-10-20 10:43:50 UTC ya make is running...
🟡 2025-10-20 12:43:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15561	15125	0	198	220	18

🟢 2025-10-20 12:43:56 UTC Build successful.
🟢 2025-10-20 12:44:20 UTC ydbd size 3.8 GiB changed* by +320 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `55d530d`	merge: `949613e`	diff	diff %
ydbd size	4 037 277 240 Bytes	4 037 277 560 Bytes	+320 Bytes	+0.000%
ydbd stripped size	1 500 150 624 Bytes	1 500 151 008 Bytes	+384 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

nshestakov · 2025-10-21T10:30:41Z

ydb/core/persqueue/pqtablet/transaction.cpp

        break;
    case NKikimrPQ::TTransaction::KIND_UNKNOWN:
-        Y_FAIL_S("unknown transaction type");
+        AFL_ENSURE(false);


а по логам поймем в какой партиии и на каком ключе это произошло? может подробностей докинуть?

Добавил макрос TX_ENSURE. Он добавляет в контекст идентификатор транзакции и состояние.
c9f42b6

github-actions · 2025-10-21T11:12:34Z

⚪ 2025-10-21 11:12:33 UTC Pre-commit check linux-x86_64-release-asan for 4717607 has started.
⚪ 2025-10-21 11:13:00 UTC Artifacts will be uploaded here
⚪ 2025-10-21 11:16:30 UTC ya make is running...
⚫ 2025-10-21 11:16:47 UTC Check cancelled

github-actions · 2025-10-21T11:14:25Z

⚪ 2025-10-21 11:14:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4717607 has started.
⚪ 2025-10-21 11:14:29 UTC Artifacts will be uploaded here
⚫ 2025-10-21 11:16:47 UTC Check cancelled

github-actions · 2025-10-21T11:17:14Z

⚪ 2025-10-21 11:17:14 UTC Pre-commit check linux-x86_64-release-asan for e5bef6b has started.
⚪ 2025-10-21 11:17:18 UTC Artifacts will be uploaded here
⚪ 2025-10-21 11:20:48 UTC ya make is running...
🟡 2025-10-21 13:22:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15589	15049	0	294	225	21

🟢 2025-10-21 13:22:57 UTC Build successful.
🟢 2025-10-21 13:23:19 UTC ydbd size 3.8 GiB changed* by +10.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fa20676`	merge: `e5bef6b`	diff	diff %
ydbd size	4 040 139 376 Bytes	4 040 150 208 Bytes	+10.6 KiB	+0.000%
ydbd stripped size	1 500 998 336 Bytes	1 501 003 456 Bytes	+5.0 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-10-21T11:20:26Z

⚪ 2025-10-21 11:20:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for e5bef6b has started.
⚪ 2025-10-21 11:20:39 UTC Artifacts will be uploaded here
⚪ 2025-10-21 11:24:18 UTC ya make is running...
🟡 2025-10-21 12:57:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31394	29989	0	9	1377	19

⚪ 2025-10-21 12:57:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-21 13:21:50 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
973 (only retried tests)	954	0	0	0	19

🟢 2025-10-21 13:21:52 UTC Build successful.
🟢 2025-10-21 13:22:09 UTC ydbd size 2.3 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fa20676`	merge: `e5bef6b`	diff	diff %
ydbd size	2 428 096 080 Bytes	2 428 103 744 Bytes	+7.5 KiB	+0.000%
ydbd stripped size	516 612 424 Bytes	516 615 112 Bytes	+2.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Alek5andr-Kotov requested a review from a team as a code owner October 18, 2025 08:46

Alek5andr-Kotov requested a review from a-serebryanskiy October 18, 2025 08:46

github-actions bot added the not-for-changelog label Oct 18, 2025

Alek5andr-Kotov mentioned this pull request Oct 18, 2025

[stable-25-3-1] VERIFY failed ydb/core/persqueue/pqtablet/transaction.cpp:54: TDistributedTransaction #25704

Closed

Alek5andr-Kotov enabled auto-merge (squash) October 18, 2025 08:47

nshestakov reviewed Oct 21, 2025

View reviewed changes

Alek5andr-Kotov added 4 commits October 21, 2025 14:16

[+] logging

4db79e7

[-] broken build

bdf14e6

[+] TX_ENSURE

06d06f1

[*] restart instead of logging

d444402

Alek5andr-Kotov force-pushed the LOGBROKER-10027 branch from 3664b87 to d444402 Compare October 21, 2025 11:16

nshestakov approved these changes Oct 21, 2025

View reviewed changes

Alek5andr-Kotov merged commit 3a6947b into ydb-platform:main Oct 21, 2025
12 checks passed

ydbot pushed a commit that referenced this pull request Oct 21, 2025

Y_FAIL_S in the TDistributedTransaction constructor (#27103)

e1da5d1

ydbot mentioned this pull request Oct 21, 2025

stable-25-3: Y_FAIL_S in the TDistributedTransaction constructor #27233

Merged

ydbot pushed a commit that referenced this pull request Oct 21, 2025

Y_FAIL_S in the TDistributedTransaction constructor (#27103)

f096077

ydbot mentioned this pull request Oct 21, 2025

stable-25-3-1: Y_FAIL_S in the TDistributedTransaction constructor #27234

Merged

Uh oh!

Y_FAIL_S in the TDistributedTransaction constructor #27103

Y_FAIL_S in the TDistributedTransaction constructor #27103

Uh oh!

Conversation

Alek5andr-Kotov commented Oct 18, 2025

Changelog entry

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

github-actions bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nshestakov Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Alek5andr-Kotov Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 18, 2025 •

edited

Loading

github-actions bot commented Oct 18, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading