Skip to content

Conversation

@ztlpn
Copy link
Collaborator

@ztlpn ztlpn commented Oct 14, 2025

@ztlpn ztlpn requested review from azevaykin and ijon October 14, 2025 17:00
@ztlpn ztlpn requested review from a team as code owners October 14, 2025 17:00
@ztlpn ztlpn self-assigned this Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

🟢 2025-10-22 12:39:49 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

2025-10-14 17:03:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for ced8a82 has started.
2025-10-14 17:04:13 UTC Artifacts will be uploaded here
2025-10-14 17:08:31 UTC ya make is running...
🟡 2025-10-14 19:27:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41197 38413 0 1 2761 22

2025-10-14 19:28:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-14 19:44:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
994 (only retried tests) 973 0 1 0 20

2025-10-14 19:44:22 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-14 19:58:40 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
570 (only retried tests) 548 0 0 0 22

🟢 2025-10-14 19:58:43 UTC Build successful.
🟢 2025-10-14 19:59:02 UTC ydbd size 2.3 GiB changed* by +5.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9c08324 merge: ced8a82 diff diff %
ydbd size 2 423 377 720 Bytes 2 423 383 264 Bytes +5.4 KiB +0.000%
ydbd stripped size 515 870 856 Bytes 515 872 008 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

2025-10-14 17:04:08 UTC Pre-commit check linux-x86_64-release-asan for ced8a82 has started.
2025-10-14 17:04:23 UTC Artifacts will be uploaded here
2025-10-14 17:08:32 UTC ya make is running...
🟡 2025-10-14 19:56:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17982 17300 0 387 274 21

🟢 2025-10-14 19:56:53 UTC Build successful.
🟢 2025-10-14 19:57:16 UTC ydbd size 3.8 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9c08324 merge: ced8a82 diff diff %
ydbd size 4 031 826 480 Bytes 4 031 835 304 Bytes +8.6 KiB +0.000%
ydbd stripped size 1 497 424 512 Bytes 1 497 428 448 Bytes +3.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

azevaykin
azevaykin previously approved these changes Oct 15, 2025
Comment on lines 586 to 589
return TDuration::Seconds(
isBackup
? appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds()
: appData.DataShardConfig.GetStatsReportIntervalSeconds());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes no sense for backup table stats report intervals to be shorter than normal table report intervals.

I suggest enforcing this constraint.

Suggested change
return TDuration::Seconds(
isBackup
? appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds()
: appData.DataShardConfig.GetStatsReportIntervalSeconds());
const auto interval = appData.DataShardConfig.GetStatsReportIntervalSeconds();
return TDuration::Seconds(
isBackup
? std::max(interval, appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds()
: interval
);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ztlpn ztlpn force-pushed the datashard-configurable-stats-interval branch from 12c70a0 to 6decd0c Compare October 15, 2025 10:53
@ztlpn ztlpn requested a review from ijon October 15, 2025 10:54
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 16:50:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 17b6ac3 has started.
2025-10-15 16:50:14 UTC Artifacts will be uploaded here
2025-10-15 16:54:31 UTC ya make is running...
🟢 2025-10-15 18:28:17 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41217 38450 0 0 2743 24

🟢 2025-10-15 18:28:27 UTC Build successful.
🟢 2025-10-15 18:28:41 UTC ydbd size 2.3 GiB changed* by +6.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6a97bc6 merge: 17b6ac3 diff diff %
ydbd size 2 423 994 432 Bytes 2 424 000 632 Bytes +6.1 KiB +0.000%
ydbd stripped size 515 998 440 Bytes 515 999 592 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ztlpn ztlpn requested a review from azevaykin October 15, 2025 10:56
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 10:59:49 UTC Pre-commit check linux-x86_64-release-asan for 17b6ac3 has started.
2025-10-15 10:59:53 UTC Artifacts will be uploaded here
2025-10-15 11:04:08 UTC ya make is running...
🟡 2025-10-15 14:04:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18002 17500 0 185 295 22

🟢 2025-10-15 14:04:32 UTC Build successful.
🟢 2025-10-15 14:04:56 UTC ydbd size 3.8 GiB changed* by +9.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6a97bc6 merge: 17b6ac3 diff diff %
ydbd size 4 032 942 864 Bytes 4 032 952 816 Bytes +9.7 KiB +0.000%
ydbd stripped size 1 497 804 320 Bytes 1 497 808 576 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ztlpn ztlpn merged commit efa0852 into ydb-platform:main Oct 15, 2025
20 of 22 checks passed
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 17, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/sys_view/ut_common.h
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
ztlpn added a commit to ztlpn/ydb that referenced this pull request Oct 22, 2025
(cherry picked from commit efa0852)

Conflicts:
	ydb/core/protos/datashard_config.proto
	ydb/core/sys_view/ut_common.h
	ydb/core/sys_view/ut_kqp.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.cpp
	ydb/core/tx/schemeshard/ut_helpers/test_env.h
	ydb/core/tx/schemeshard/ut_split_merge/ut_split_merge.cpp
	ydb/core/tx/schemeshard/ut_subdomain/ut_subdomain.cpp
	ydb/services/ydb/ydb_table_split_ut.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants