-
Couldn't load subscription status.
- Fork 726
Datashard configurable stats report intervals #26862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datashard configurable stats report intervals #26862
Conversation
KIKIMR-24154
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| return TDuration::Seconds( | ||
| isBackup | ||
| ? appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds() | ||
| : appData.DataShardConfig.GetStatsReportIntervalSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no sense for backup table stats report intervals to be shorter than normal table report intervals.
I suggest enforcing this constraint.
| return TDuration::Seconds( | |
| isBackup | |
| ? appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds() | |
| : appData.DataShardConfig.GetStatsReportIntervalSeconds()); | |
| const auto interval = appData.DataShardConfig.GetStatsReportIntervalSeconds(); | |
| return TDuration::Seconds( | |
| isBackup | |
| ? std::max(interval, appData.DataShardConfig.GetBackupTableStatsReportIntervalSeconds() | |
| : interval | |
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
12c70a0 to
6decd0c
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
(cherry picked from commit efa0852)
(cherry picked from commit efa0852)
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/sys_view/ut_common.h ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h
(cherry picked from commit efa0852) Conflicts: ydb/core/protos/datashard_config.proto ydb/core/sys_view/ut_common.h ydb/core/sys_view/ut_kqp.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.cpp ydb/core/tx/schemeshard/ut_helpers/test_env.h ydb/core/tx/schemeshard/ut_split_merge/ut_split_merge.cpp ydb/core/tx/schemeshard/ut_subdomain/ut_subdomain.cpp ydb/services/ydb/ydb_table_split_ut.cpp
Changelog category
Description for reviewers
KIKIMR-24154
KIKIMR-24179
PRs in stable branches: