Skip to content

fix pk usage in writing v0 chunks #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable-25-1
Choose a base branch
from

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented May 7, 2025

Partial cherry-pick of #17830 (only fix, without normalizer)

@swalrus1 swalrus1 marked this pull request as ready for review May 7, 2025 07:54
@swalrus1 swalrus1 requested a review from a team as a code owner May 7, 2025 07:54
Copy link

github-actions bot commented May 7, 2025

2025-05-07 07:55:00 UTC Pre-commit check linux-x86_64-release-asan for 7243d83 has started.
2025-05-07 07:55:12 UTC Artifacts will be uploaded here
2025-05-07 07:58:10 UTC ya make is running...
🟡 2025-05-07 09:14:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11963 11755 0 112 60 36

2025-05-07 09:15:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-07 09:36:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
253 (only retried tests) 164 0 9 47 33

2025-05-07 09:36:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-07 09:57:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 47 0 7 30 33

🟢 2025-05-07 09:57:49 UTC Build successful.
🟢 2025-05-07 09:58:18 UTC ydbd size 3.6 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 1523d35 merge: 7243d83 diff diff %
ydbd size 3 911 204 256 Bytes 3 911 208 304 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 368 049 104 Bytes 1 368 049 616 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 7, 2025

2025-05-07 07:56:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7243d83 has started.
2025-05-07 07:56:30 UTC Artifacts will be uploaded here
2025-05-07 07:59:18 UTC ya make is running...
🟡 2025-05-07 08:57:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18783 17499 0 3 1222 59

2025-05-07 08:59:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-07 09:19:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 74 0 0 0 58

🟢 2025-05-07 09:19:40 UTC Build successful.
🟢 2025-05-07 09:19:58 UTC ydbd size 2.1 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 1523d35 merge: 7243d83 diff diff %
ydbd size 2 248 485 552 Bytes 2 248 487 840 Bytes +2.2 KiB +0.000%
ydbd stripped size 475 855 800 Bytes 475 855 992 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 7, 2025

🟢 2025-05-07 07:58:27 UTC The validation of the Pull Request description is successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant