Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-4052 fixed url escaping for s3 insert #13891

Merged
merged 8 commits into from
Jan 29, 2025
Merged

YQ-4052 fixed url escaping for s3 insert #13891

merged 8 commits into from
Jan 29, 2025

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Jan 27, 2025 •
edited
Loading

Changelog entry

Fixed url escaping for s3 insert

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner January 27, 2025 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

⚪ 2025-01-27 14:46:30 UTC Pre-commit check linux-x86_64-release-asan for 6982bbe has started.
⚪ 2025-01-27 14:46:59 UTC Artifacts will be uploaded here
⚪ 2025-01-27 14:50:30 UTC ya make is running...
🟡 2025-01-27 15:47:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11086 11021 0 23 12 30

⚪ 2025-01-27 15:48:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-27 16:00:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 66 0 4 2 26

⚪ 2025-01-27 16:01:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-27 16:12:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 23 0 3 3 25

🟢 2025-01-27 16:12:54 UTC Build successful.
🟢 2025-01-27 16:13:23 UTC ydbd size 3.6 GiB changed* by +11.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afd8c9e merge: 6982bbe diff diff %
ydbd size 3 864 157 024 Bytes 3 864 168 776 Bytes +11.5 KiB +0.000%
ydbd stripped size 1 351 468 880 Bytes 1 351 474 320 Bytes +5.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

⚪ 2025-01-27 14:49:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6982bbe has started.
⚪ 2025-01-27 14:49:19 UTC Artifacts will be uploaded here
⚪ 2025-01-27 14:52:22 UTC ya make is running...
🟡 2025-01-27 15:54:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25187 22656 0 3 2409 119

⚪ 2025-01-27 15:57:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-27 16:06:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 65 0 0 0 116

🟢 2025-01-27 16:06:50 UTC Build successful.
🟢 2025-01-27 16:07:09 UTC ydbd size 2.1 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afd8c9e merge: 6982bbe diff diff %
ydbd size 2 223 845 560 Bytes 2 223 849 088 Bytes +3.4 KiB +0.000%
ydbd stripped size 470 207 824 Bytes 470 208 336 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA force-pushed the YQ-4052-fix-url-escaping-for-s3-insert branch from 5e413f3 to 9c6c381 Compare January 27, 2025 18:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

⚪ 2025-01-27 18:24:57 UTC Pre-commit check linux-x86_64-release-asan for e41084f has started.
⚪ 2025-01-27 18:25:24 UTC Artifacts will be uploaded here
⚪ 2025-01-27 18:28:57 UTC ya make is running...
🟡 2025-01-27 19:30:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11091 11019 0 22 17 33

⚪ 2025-01-27 19:32:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-27 19:45:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 71 0 5 3 29

⚪ 2025-01-27 19:45:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-27 19:57:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 29 0 3 2 28

🟢 2025-01-27 19:57:38 UTC Build successful.
🟢 2025-01-27 19:58:05 UTC ydbd size 3.6 GiB changed* by +7.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 818a8a0 merge: e41084f diff diff %
ydbd size 3 864 227 280 Bytes 3 864 235 216 Bytes +7.8 KiB +0.000%
ydbd stripped size 1 351 488 656 Bytes 1 351 490 320 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

⚪ 2025-01-27 18:25:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for e41084f has started.
⚪ 2025-01-27 18:25:35 UTC Artifacts will be uploaded here
⚪ 2025-01-27 18:28:29 UTC ya make is running...
🟡 2025-01-27 19:29:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25192 22657 0 4 2404 127

⚪ 2025-01-27 19:31:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-27 19:41:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 72 0 0 0 119

🟢 2025-01-27 19:41:48 UTC Build successful.
🟢 2025-01-27 19:42:08 UTC ydbd size 2.1 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 818a8a0 merge: e41084f diff diff %
ydbd size 2 223 875 304 Bytes 2 223 879 512 Bytes +4.1 KiB +0.000%
ydbd stripped size 470 212 208 Bytes 470 212 848 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 07:39:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b97fe0 has started.
⚪ 2025-01-28 07:39:57 UTC Artifacts will be uploaded here
⚫ 2025-01-28 07:40:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 07:42:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 130e37c has started.
⚪ 2025-01-28 07:43:09 UTC Artifacts will be uploaded here
⚪ 2025-01-28 07:46:12 UTC ya make is running...
🟡 2025-01-28 08:48:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25802 23256 0 6 2416 124

⚪ 2025-01-28 08:51:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-28 09:03:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 68 0 1 0 120

⚪ 2025-01-28 09:03:39 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-28 09:13:11 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 56 0 1 0 118

🟢 2025-01-28 09:13:19 UTC Build successful.
🟢 2025-01-28 09:13:42 UTC ydbd size 2.1 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 44b7587 merge: 130e37c diff diff %
ydbd size 2 224 137 040 Bytes 2 224 141 200 Bytes +4.1 KiB +0.000%
ydbd stripped size 470 246 384 Bytes 470 247 088 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 07:44:47 UTC Pre-commit check linux-x86_64-release-asan for 130e37c has started.
⚪ 2025-01-28 07:44:59 UTC Artifacts will be uploaded here
⚪ 2025-01-28 07:47:51 UTC ya make is running...
🟡 2025-01-28 09:15:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11479 11411 0 27 9 32

⚪ 2025-01-28 09:16:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 09:24:39 UTC ydbd size 3.6 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 44b7587 merge: 130e37c diff diff %
ydbd size 3 864 804 800 Bytes 3 864 812 416 Bytes +7.4 KiB +0.000%
ydbd stripped size 1 351 603 472 Bytes 1 351 605 008 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-01-28 09:24:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 09:26:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6353cb4 has started.
⚪ 2025-01-28 09:27:47 UTC Artifacts will be uploaded here
⚫ 2025-01-28 09:30:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 09:27:26 UTC Pre-commit check linux-x86_64-release-asan for 6353cb4 has started.
⚪ 2025-01-28 09:28:03 UTC Artifacts will be uploaded here
⚫ 2025-01-28 09:30:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 09:31:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2a95c1f has started.
⚪ 2025-01-28 09:31:25 UTC Artifacts will be uploaded here
⚪ 2025-01-28 09:34:21 UTC ya make is running...
⚫ 2025-01-28 10:40:03 UTC Check cancelled

@GrigoriyPA GrigoriyPA requested a review from dorooleg January 28, 2025 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 09:34:50 UTC Pre-commit check linux-x86_64-release-asan for 2a95c1f has started.
⚪ 2025-01-28 09:34:54 UTC Artifacts will be uploaded here
⚪ 2025-01-28 09:37:45 UTC ya make is running...
⚫ 2025-01-28 10:40:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 10:41:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0089ea has started.
⚪ 2025-01-28 10:41:35 UTC Artifacts will be uploaded here
⚪ 2025-01-28 10:45:20 UTC ya make is running...
⚫ 2025-01-28 11:06:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 10:43:18 UTC Pre-commit check linux-x86_64-release-asan for f0089ea has started.
⚪ 2025-01-28 10:43:33 UTC Artifacts will be uploaded here
⚪ 2025-01-28 10:46:26 UTC ya make is running...
⚫ 2025-01-28 11:06:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 11:10:14 UTC Pre-commit check linux-x86_64-release-asan for 2383c55 has started.
⚪ 2025-01-28 11:10:26 UTC Artifacts will be uploaded here
⚪ 2025-01-28 11:13:20 UTC ya make is running...
🟡 2025-01-28 12:10:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11480 11414 0 16 13 37

⚪ 2025-01-28 12:11:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-28 12:27:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 65 0 3 3 29

⚪ 2025-01-28 12:27:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-28 12:39:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 28 0 2 2 28

🟢 2025-01-28 12:39:31 UTC Build successful.
🟢 2025-01-28 12:40:01 UTC ydbd size 3.6 GiB changed* by +7.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 777ff9a merge: 2383c55 diff diff %
ydbd size 3 864 980 680 Bytes 3 864 988 616 Bytes +7.8 KiB +0.000%
ydbd stripped size 1 351 619 888 Bytes 1 351 621 552 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 11:10:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2383c55 has started.
⚪ 2025-01-28 11:10:40 UTC Artifacts will be uploaded here
⚪ 2025-01-28 11:13:45 UTC ya make is running...
🟡 2025-01-28 12:06:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25805 23257 0 1 2420 127

⚪ 2025-01-28 12:08:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 12:18:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 70 0 0 0 121

🟢 2025-01-28 12:18:27 UTC Build successful.
🟢 2025-01-28 12:18:46 UTC ydbd size 2.1 GiB changed* by +4.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 777ff9a merge: 2383c55 diff diff %
ydbd size 2 224 267 728 Bytes 2 224 272 000 Bytes +4.2 KiB +0.000%
ydbd stripped size 470 252 016 Bytes 470 252 720 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 13:16:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3939e8a has started.
⚪ 2025-01-28 13:16:33 UTC Artifacts will be uploaded here
⚪ 2025-01-28 13:19:30 UTC ya make is running...
🟡 2025-01-28 15:53:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25810 23257 0 3 2423 127

⚪ 2025-01-28 15:57:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-28 16:07:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 80 0 0 0 118

🟢 2025-01-28 16:07:47 UTC Build successful.
🟢 2025-01-28 16:08:06 UTC ydbd size 2.1 GiB changed* by +13.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e756b37 merge: 3939e8a diff diff %
ydbd size 2 224 264 464 Bytes 2 224 278 672 Bytes +13.9 KiB +0.001%
ydbd stripped size 470 251 248 Bytes 470 253 488 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚪ 2025-01-28 13:17:31 UTC Pre-commit check linux-x86_64-release-asan for 3939e8a has started.
⚪ 2025-01-28 13:17:43 UTC Artifacts will be uploaded here
⚪ 2025-01-28 13:20:36 UTC ya make is running...
🟡 2025-01-28 14:24:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11485 11388 0 44 19 34

⚪ 2025-01-28 14:26:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-28 14:39:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 111 0 4 5 27

⚪ 2025-01-28 14:39:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-28 14:51:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 33 0 2 1 25

🟢 2025-01-28 14:51:25 UTC Build successful.
🟢 2025-01-28 14:51:54 UTC ydbd size 3.6 GiB changed* by +28.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e756b37 merge: 3939e8a diff diff %
ydbd size 3 864 974 472 Bytes 3 865 003 328 Bytes +28.2 KiB +0.001%
ydbd stripped size 1 351 618 096 Bytes 1 351 628 528 Bytes +10.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 1ce4d3d into ydb-platform:main Jan 29, 2025
12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4052-fix-url-escaping-for-s3-insert branch January 29, 2025 15:12
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Jan 29, 2025
@GrigoriyPA
YQ-4052 fixed url escaping for s3 insert (ydb-platform#13891)
94d179c
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Jan 29, 2025
@GrigoriyPA
YQ-4052 fixed url escaping for s3 insert (ydb-platform#13891)
eafe171
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 30, 2025
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Jan 30, 2025
@GrigoriyPA @stanislav-shchetinin
YQ-4052 fixed url escaping for s3 insert (ydb-platform#13891)
7e944db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanevanevanevannnn evanevanevanevannnn evanevanevanevannnn approved these changes

@dorooleg dorooleg dorooleg approved these changes

@uzhastik uzhastik Awaiting requested review from uzhastik

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrigoriyPA @dorooleg @evanevanevanevannnn