Making GrpcStreamRetrier ID configurable #492
Open
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
============================================
- Coverage 58.15% 58.12% -0.04%
Complexity 2183 2183
============================================
Files 325 325
Lines 13216 13226 +10
Branches 1330 1331 +1
============================================
+ Hits 7686 7687 +1
- Misses 4907 4914 +7
- Partials 623 625 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alex268
reviewed
May 26, 2025
Myllyenko
force-pushed
the
making-grpc-retrier-id-configurable
branch
from
23d5b5e to
9856a4b
Compare
Myllyenko
force-pushed
the
making-grpc-retrier-id-configurable
branch
from
9856a4b to
337b12f
Compare
alex268
approved these changes
May 27, 2025
pnv1
reviewed
May 27, 2025
| * | ||
| * @return this builder | ||
| */ | ||
| public Builder setDebugId(String debugId) { |
There was a problem hiding this comment.
LogId looks better IMO, more specific.
Or LogPrefix to be even more specific
There was a problem hiding this comment.
Just to be sure: are you sure that this ID won't be useful for other observability purposes?
There was a problem hiding this comment.
I don't think so. That identifier was created and is used for debug purpose only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
GrpcStreamRetrierand its subclasses use autogenerated ID to identify themselves in logs. Such approach highly complicates correlating YDB SDK and application logs. To simplify logs correlation, in this PR the ID is being made configurable, so a user can provide his or her value uponGrpcStreamRetriercreation.