Skip to content

Commit

Permalink
Merge pull request #22 from alex268/master
Browse files Browse the repository at this point in the history
Upgrade dependencies and fix logging problems
  • Loading branch information
alex268 authored Feb 2, 2024
2 parents b08478d + 9bebfc2 commit 88d6f6f
Show file tree
Hide file tree
Showing 12 changed files with 62 additions and 57 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'temurin'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'temurin'
Expand Down
4 changes: 2 additions & 2 deletions jdbc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
<packaging>pom</packaging>

<properties>
<ydb.jdbc.version>2.0.2</ydb.jdbc.version>
<slf4j.version>1.7.25</slf4j.version>
<ydb.jdbc.version>2.0.6</ydb.jdbc.version>
<slf4j.version>1.7.36</slf4j.version>
</properties>

<modules>
Expand Down
14 changes: 0 additions & 14 deletions jdbc/spring-data-jpa-v5/src/main/resources/log4j2.xml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
spring.jpa.show-sql=true
spring.jpa.properties.hibernate.format_sql=true
spring.jpa.properties.hibernate.format_sql=false
spring.jpa.properties.hibernate.highlight_sql=true

spring.jpa.properties.hibernate.hbm2ddl.auto=create
19 changes: 19 additions & 0 deletions jdbc/spring-data-jpa-v5/src/test/resources/logback.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<appender name="console" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>%d %5p %40.40c:%4L - %m%n</pattern>
</encoder>
</appender>

<!-- https://www.testcontainers.org/supported_docker_environment/logging_config/ -->
<logger name="org.testcontainers" level="warn" />
<logger name="com.github.dockerjava" level="warn"/>
<logger name="com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire" level="off"/>

<logger name="org.hibernate.SQL" additivity="true" level="debug" />

<root level="warn">
<appender-ref ref="console" />
</root>
</configuration>
21 changes: 8 additions & 13 deletions jdbc/spring-data-jpa/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<maven.compiler.release>17</maven.compiler.release>
<kotlin.version>1.9.22</kotlin.version>
<hibernate.ydb.dialect.version>0.9.1</hibernate.ydb.dialect.version>
<ydb.jdbc.driver.version>2.0.5</ydb.jdbc.driver.version>
<spring.boot.version>3.2.1</spring.boot.version>
</properties>
<dependencies>
Expand Down Expand Up @@ -44,18 +43,13 @@
</dependency>
<dependency>
<groupId>tech.ydb.jdbc</groupId>
<artifactId>ydb-jdbc-driver</artifactId>
<version>${ydb.jdbc.driver.version}</version>
<artifactId>ydb-jdbc-driver-shaded</artifactId>
</dependency>
<dependency>
<groupId>com.github.javafaker</groupId>
<artifactId>javafaker</artifactId>
<version>1.0.2</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlinx</groupId>
<artifactId>kotlinx-coroutines-core</artifactId>
Expand All @@ -72,6 +66,13 @@
<version>1.19.1</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<version>${spring.boot.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>tech.ydb.test</groupId>
<artifactId>ydb-junit5-support</artifactId>
Expand All @@ -83,12 +84,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<version>${spring.boot.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<sourceDirectory>${project.basedir}/src/main/kotlin</sourceDirectory>
Expand Down
14 changes: 0 additions & 14 deletions jdbc/spring-data-jpa/src/main/resources/log4j2.xml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
spring.jpa.show-sql=true
spring.jpa.properties.hibernate.format_sql=true
spring.jpa.properties.hibernate.format_sql=false
spring.jpa.properties.hibernate.highlight_sql=true

spring.jpa.properties.hibernate.hbm2ddl.auto=create
19 changes: 19 additions & 0 deletions jdbc/spring-data-jpa/src/test/resources/logback.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<appender name="console" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>%d %5p %40.40c:%4L - %m%n</pattern>
</encoder>
</appender>

<!-- https://www.testcontainers.org/supported_docker_environment/logging_config/ -->
<logger name="org.testcontainers" level="warn" />
<logger name="com.github.dockerjava" level="warn"/>
<logger name="com.github.dockerjava.zerodep.shaded.org.apache.hc.client5.http.wire" level="off"/>

<logger name="org.hibernate.SQL" additivity="true" level="debug" />

<root level="info">
<appender-ref ref="console" />
</root>
</configuration>
10 changes: 5 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<log4j.version>2.20.0</log4j.version>
<log4j.version>2.22.1</log4j.version>
<jcommander.version>1.82</jcommander.version>

<ydb.sdk.version>2.1.7</ydb.sdk.version>
<ydb.sdk.version>2.1.11</ydb.sdk.version>
</properties>

<modules>
Expand Down Expand Up @@ -66,7 +66,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<version>3.12.1</version>
<configuration>
<target>1.8</target>
<source>1.8</source>
Expand All @@ -81,7 +81,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.1.0</version>
<version>3.2.5</version>
<configuration>
<environmentVariables>
<TESTCONTAINERS_REUSE_ENABLE>true</TESTCONTAINERS_REUSE_ENABLE>
Expand All @@ -91,7 +91,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.5.0</version>
<version>3.6.1</version>
<executions>
<execution>
<id>copy-dependencies</id>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package tech.ydb.examples.simple;

import java.time.Duration;

import tech.ydb.core.grpc.GrpcTransport;
import tech.ydb.examples.SimpleExample;
import tech.ydb.table.Session;
import tech.ydb.table.TableClient;
import tech.ydb.table.description.TableColumn;
import tech.ydb.table.description.TableDescription;
import tech.ydb.table.settings.AlterTableSettings;
import tech.ydb.table.values.OptionalType;
import tech.ydb.table.values.PrimitiveType;


Expand Down Expand Up @@ -42,8 +42,8 @@ protected void run(GrpcTransport transport, String pathPrefix) {

session.alterTable(tablePath, new AlterTableSettings()
.setTraceId("some-trace-id")
.addColumn("name", OptionalType.of(PrimitiveType.Text))
.addColumn("age", OptionalType.of(PrimitiveType.Uint32))
.addNullableColumn("name", PrimitiveType.Text)
.addNullableColumn("age", PrimitiveType.Uint32)
.dropColumn("value")
).join().expectSuccess("cannot alter table");

Expand Down

0 comments on commit 88d6f6f

Please sign in to comment.