Skip to content

Fix error logging for UpdateOffsetsInTransaction #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

Fix error logging for UpdateOffsetsInTransaction #1856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1235b0d
Fix error logging for UpdateOffsetsInTransaction
kprokopenko Sep 5, 2025
b6f315f
add Changelog
kprokopenko Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Fixed error logging in `topic.UpdateOffsetsInTransaction`

## v3.115.4
* Supported reusing one IP address and host name after nodes restart

Expand Down
19 changes: 10 additions & 9 deletions internal/topic/topicreaderinternal/stream_reader_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,16 +232,17 @@ func (r *topicStreamReaderImpl) commitWithTransaction(

req := r.createUpdateOffsetRequest(ctx, batch, tx)
updateOffsetInTransactionErr := retry.Retry(ctx, func(ctx context.Context) (err error) {
logCtx := r.cfg.BaseContext
onDone := trace.TopicOnReaderUpdateOffsetsInTransaction(
r.cfg.Trace,
&logCtx,
r.readerID,
r.readConnectionID,
tx.SessionID(),
tx,
)
defer func() {
logCtx := r.cfg.BaseContext
trace.TopicOnReaderUpdateOffsetsInTransaction(
r.cfg.Trace,
&logCtx,
r.readerID,
r.readConnectionID,
tx.SessionID(),
tx,
)
onDone(err)
}()

err = r.topicClient.UpdateOffsetsInTransaction(ctx, req)
Expand Down
Loading