Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed test with drop user on nightly ydb #1597

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.16%. Comparing base (44135d1) to head (25b7f8a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   67.77%   71.16%   +3.39%     
==========================================
  Files         372      372              
  Lines       38267    38267              
==========================================
+ Hits        25934    27234    +1300     
+ Misses      11222     9907    -1315     
- Partials     1111     1126      +15     
Flag Coverage Δ
experiment 70.24% <ø> (?)
go-1.22.x 67.84% <ø> (+<0.01%) ⬆️
go-1.23.x 71.15% <ø> (+30.27%) ⬆️
integration 51.40% <ø> (+0.36%) ⬆️
macOS 40.87% <ø> (-0.02%) ⬇️
ubuntu 71.16% <ø> (+3.40%) ⬆️
unit 40.89% <ø> (-0.01%) ⬇️
windows 40.88% <ø> (+0.01%) ⬆️
ydb-24.1 51.35% <ø> (?)
ydb-24.2 51.23% <ø> (?)
ydb-24.3 51.29% <ø> (+0.26%) ⬆️
ydb-nightly 70.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

ConnectorOption: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql.Option to Option

summary

Base version: v3.95.4-0.20241223074900-44135d13bdfc (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.95.3.

@asmyasnikov asmyasnikov merged commit edfe0cf into master Dec 23, 2024
21 of 50 checks passed
@asmyasnikov asmyasnikov deleted the fix-experimental branch December 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants